]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
WindowTracker: fix ref counting bug in get_app_for_window()
authorGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 27 Jun 2012 17:14:27 +0000 (19:14 +0200)
committerGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 27 Jun 2012 17:27:30 +0000 (19:27 +0200)
get_app_for_window() is (transfer full), but shell_app_system_lookup_wmclass()
is (transfer none), so we must reference the result, or crash
occur.

https://bugzilla.gnome.org/show_bug.cgi?id=678992

src/shell-window-tracker.c

index b97f5422a2fe782e7e8eaf86007c1f48be17e3f1..d2cc7a82c375d52be1c6ffebf828ddad05117da6 100644 (file)
@@ -299,7 +299,7 @@ get_app_for_window (ShellWindowTracker    *tracker,
   result = shell_app_system_lookup_wmclass (app_system,
                                             meta_window_get_wm_class (window));
   if (result != NULL)
-    return result;
+    return g_object_ref (result);
 
   result = get_app_from_window_pid (tracker, window);
   if (result != NULL)